Page 7 of 9
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Mon Nov 27, 2017 11:41 am
by RIP Syndrome
Cool.
I actually have a question about the contact icons, though. Are we going to keep the new system where they're all grouped under the single icon, or is the old system with the separate icons returning? I'm asking because honestly I think this new way looks way nicer than the old row of icons. About the only thing I'd change was remove the Contact: bit entirely and just have the icon to reduce clutter, but knowing phpBB it's probably a huge pain to change anyway, and doesn't really matter.
Re: WTF Happened? Recent events FAQ
Posted: Mon Nov 27, 2017 11:43 am
by Adiwan
The full editior's options have it covered
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Mon Nov 27, 2017 11:44 am
by CosmogenicLily
No, the intent is to leave it as it is. I might revisit and style the pop-up to look more like the old style icons, but that would be the only possible change.
Re: WTF Happened? Recent events FAQ
Posted: Mon Nov 27, 2017 11:45 am
by SlateSlabrock
"Disable BBCode" and "Do not automatically parse URLs" don't actually stop it from embedding tweets.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Mon Nov 27, 2017 11:47 am
by RIP Syndrome
Yeah, I suppose the icons are a bit more wonky-looking than the old ones. But I'm glad to know the new setup is staying.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Mon Nov 27, 2017 3:02 pm
by CosmogenicLily
Noted issues (elsewhere): Disable BBCode/Smart URLs does not disable media handling
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Tue Nov 28, 2017 3:07 pm
by Octavia
One thing I noticed is for the main forums that have subforums, the entire icon (speech bubbles on the left) lights up on a new post, regardless of whether that happens in the main forum or the subforum.
In the screenshot below, there are unread posts in PPPP, but there are no new posts in Funland Arcade, yet both the big and little speech bubbles are lit up.
I don't have a screenshot for it, but the reverse also causes the same issue. So if there are no new posts in Applejack's Cider Stand, but there are unread posts in Twilight's Soapbox, then both the big and little speech bubbles will be lit. I'm using Race, but this issue appears to happen in all themes.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Tue Nov 28, 2017 3:17 pm
by Adiwan
I'm also a bit annoyed whenever a subforum has a new post the parent forum's icon is lit up. To some degree it's logical but also annoying to the same degree.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Tue Nov 28, 2017 4:53 pm
by CosmogenicLily
Octavia wrote: ↑Tue Nov 28, 2017 3:07 pm
One thing I noticed is for the main forums that have subforums, the entire icon (speech bubbles on the left) lights up on a new post, regardless of whether that happens in the main forum or the subforum.
In the screenshot below, there are unread posts in PPPP, but there are no new posts in Funland Arcade, yet both the big and little speech bubbles are lit up.
I don't have a screenshot for it, but the reverse also causes the same issue. So if there are no new posts in Applejack's Cider Stand, but there are unread posts in Twilight's Soapbox, then both the big and little speech bubbles will be lit. I'm using Race, but this issue appears to happen in all themes.
Yes, this is an unfortunate, but deliberate, change in the new themes. The method I was using to determine which variation to show (Subforum unread, forum read; Subforum read, forum unread; etc) isn’t as nicely compatible with the way phpBB encourages developers to do mods today. As a result I set the task aside and pushed forward with just trying to get Shine and the other themes out there. I can try revisiting the issue, but it’s a non-trivial problem to solve.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Tue Nov 28, 2017 6:55 pm
by Pocket
Text box for entering posts is still in Trebuchet, and we still have the (redundant, since the big icons change color if there are unread posts) red piece-of-paper icons in thread titles, which weren't in the first-gen verb themes.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Tue Nov 28, 2017 8:48 pm
by Jill
minor thing: the width of the quick reply field seems to match that of the full reply field in that it leaves blank space where the smilies pane and stuff would be:
i only noticed because it makes the full editor & submit buttons look off-center
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Tue Nov 28, 2017 10:16 pm
by Pocket
I'm OK with the width because it's also about the same width as the posts themselves, which in turn are about as wide as a single-column document on standard office paper. I hear it said (by graphic design and typesetting professionals) that if a body of continuous text is too wide, it gets harder to keep track of what line you were on when your eyes move back to the left to read the next line.
But that does seem a bit different from before; maybe it used to be centered?
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Tue Nov 28, 2017 11:45 pm
by CosmogenicLily
Pocket wrote: ↑Tue Nov 28, 2017 6:55 pm
Text box for entering posts is still in Trebuchet
I am aware, and elected to only remove Trebuchet from the display of posts. I don't see a huge problem with text boxes unless people do have a problem with it.
Pocket wrote: ↑Tue Nov 28, 2017 6:55 pm
And we still have the (redundant, since the big icons change color if there are unread posts) red piece-of-paper icons in thread titles, which weren't in the first-gen verb themes.
I've been debating dropping those icons, but haven't as yet.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Tue Nov 28, 2017 11:46 pm
by CosmogenicLily
Jill wrote: ↑Tue Nov 28, 2017 8:48 pm
minor thing: the width of the quick reply field seems to match that of the full reply field in that it leaves blank space where the smilies pane and stuff would be:
i only noticed because it makes the full editor & submit buttons look off-center
Due to the nature of how textboxes like that work, I couldn't get it to expand with a full width in my initial prodding at it.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Wed Nov 29, 2017 12:11 am
by CosmogenicLily
Just spent a little bit of time working with Void to fix search. It should actually be super quick again.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Wed Nov 29, 2017 4:55 am
by RIP Syndrome
ComradeCosmobot wrote: ↑Tue Nov 28, 2017 11:45 pm
I've been debating dropping those icons, but haven't as yet.
I feel like they should stay. It adds consistency across the new and old themes and they're not ugly low-quality image files anymore either so there's no real harm in keeping them. Plus they contrast well with most of the themes and makes it far easier to see threads with new posts even at a quick glance.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Wed Nov 29, 2017 8:43 am
by RIP Syndrome
Doubleposting again, because something strange is going on with how things are laid out in my profile:
I think the gangtag/custom title might be down to me using the center bbcode tag in the text (it seems to happen to anyone using that tag), but I've got no idea what happened with the signature being offset by x amount of pixels. It's like that in the signature editor preview as well.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Thu Nov 30, 2017 4:20 pm
by Venusy
Problem with Play:
I'm guessing the postprofile border colour should be the same for both bg1 and bg2, since it looks weird having it change like this.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Thu Nov 30, 2017 4:21 pm
by RIP Syndrome
Now that you've mentioned it, I think all the themes do that. I know Race does, and it looks a little wonky, but I imagine for Race it's so the border doesn't get lost in the darker alternating postbody color.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Thu Nov 30, 2017 4:38 pm
by Venusy
Some subtle alternation would probably be alright, but this looks like the bg1 colour was intended for Play while the bg2 one was copied from a different theme.
Also, the "wrote:" text in quotes is pretty hard to read:
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Thu Nov 30, 2017 5:36 pm
by Big Boss
That separator is supposed to alternate, but it's supposed to be subtle. That should get fixed.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Thu Nov 30, 2017 10:12 pm
by CosmogenicLily
Play issues and signature margins have been fixed.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Fri Dec 01, 2017 12:44 am
by Pocket
Two other things I've spotted: The whitespace around avatars is part of the profile link. That was not the case in the before times. And the separator line between profile and post doesn't go all the way down if the post is longer than the profile. Pretty sure it used to, but I can't be positive about this one.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Fri Dec 01, 2017 7:40 am
by RIP Syndrome
No, I think the separator line always cut off at some point. I dunno why but yeah pretty sure about that one.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Fri Dec 01, 2017 8:59 am
by Octavia
ComradeCosmobot wrote: ↑Tue Nov 28, 2017 4:53 pm
Yes, this is an unfortunate, but deliberate, change in the new themes. The method I was using to determine which variation to show (Subforum unread, forum read; Subforum read, forum unread; etc) isn’t as nicely compatible with the way phpBB encourages developers to do mods today. As a result I set the task aside and pushed forward with just trying to get Shine and the other themes out there. I can try revisiting the issue, but it’s a non-trivial problem to solve.
Oubliettes and Ogres updates like every 5 minutes and it always makes me think there's a new post in Applejack's Cider Stand and it's driving me nuts
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Fri Dec 01, 2017 9:25 am
by Sailor Yue
Is there anyway to have the egosearch link back? Right now the only way you can get to it is if you have it bookmarked. I remember it being available on most if not all pages, or at least on indexes
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Fri Dec 01, 2017 9:41 am
by Fizzbuzz
Sailor Yue wrote: ↑Fri Dec 01, 2017 9:25 am
Is there anyway to have the egosearch link back? Right now the only way you can get to it is if you have it bookmarked. I remember it being available on most if not all pages, or at least on indexes
It's under the quick links menu in the top left.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Fri Dec 01, 2017 9:46 am
by Big Boss
Octavia wrote: ↑Fri Dec 01, 2017 8:59 am
Oubliettes and Ogres updates like every 5 minutes and it always makes me think there's a new post in Applejack's Cider Stand and it's driving me nuts
I may solve this problem by just not having subforums anymore.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Fri Dec 01, 2017 9:59 am
by Sailor Yue
Fizzbuzz wrote: ↑Fri Dec 01, 2017 9:41 am
It's under the quick links menu in the top left.
Aaah did not know about that. Thanks!
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Fri Dec 01, 2017 10:08 am
by Sailor Yue
The notifications drop down is not mobile friendly.
And half the time it won't load. It will blink into existence then vanish..
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Fri Dec 01, 2017 11:19 am
by PhoolCat
Big Boss wrote: ↑Fri Dec 01, 2017 9:46 am
I may solve this problem by just not having subforums anymore.
Sounds good to me
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Sat Dec 02, 2017 4:37 pm
by CosmogenicLily
Sailor Yue wrote: ↑Fri Dec 01, 2017 10:08 am
The notifications drop down is not mobile friendly.
And half the time it won't load. It will blink into existence then vanish..
This does not appear to be a trivial fix, if it's even doable.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Sun Dec 03, 2017 12:29 am
by Big Boss
There are no more sub-subforums.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Sun Dec 03, 2017 2:21 am
by Adiwan
Rejoice! No more false-positive "new post" indicators!
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Sun Dec 03, 2017 4:23 am
by PhoolCat
Big Boss wrote: ↑Sun Dec 03, 2017 12:29 am
There are no more sub-subforums.
I like this
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Sun Dec 03, 2017 4:28 pm
by Princess Flufflebutt
Only dom-forums now.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Mon Dec 04, 2017 7:04 pm
by Factory Factory
I'm using Shine but I think the problem might be broader:
Clicking the Notifications hides it. This makes it unable to be shown on mobile as you can't do a mouseover without a tap. It's also annoying on desktop because if you click it, you can't get it back until refreshing the page.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Mon Dec 04, 2017 7:53 pm
by Pocket
RIP Syndrome wrote: ↑Fri Dec 01, 2017 7:40 am
No, I think the separator line always cut off at some point. I dunno why but yeah pretty sure about that one.
It's because there's no such thing as a vertical line object in HTML. The easiest thing to do is to just give one of them a border on one side, in this case the user info box. You could also give the area surrounding both columns a background image that
looks like a vertical line when it's stretched, and it might look fine as long as it's an SVG, but I don't know if anyone here is adept at creating those.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Mon Dec 04, 2017 8:52 pm
by CosmogenicLily
Factory Factory wrote: ↑Mon Dec 04, 2017 7:04 pm
I'm using Shine but I think the problem might be broader:
Clicking the Notifications hides it. This makes it unable to be shown on mobile as you can't do a mouseover without a tap. It's also annoying on desktop because if you click it, you can't get it back until refreshing the page.
Nothing I can do about this. The Notifications link is supposed to actually link you to your notifications page, but the click event gets consumed before that happens. However, the click does screw with the hover events such that they can’t come back.
There may be some JavaScript error that kills event handling on the page, but so far I haven’t found it or found a way to fix it. Even adding onclick event handlers and using them to suppress the event before it hits the actual link doesn’t prevent the drop down from being permanently disabled.
Re: Hey the forum thinger is busted! Issues known and found.
Posted: Thu Dec 07, 2017 6:15 pm
by West Filly
The "mark all topics read" link is where the "view unread topics" link used to be